[Klone-users] Re: Merge u_config_save_to_buf() and u_config_print_to_fp() ?

[thomas fossati]

Hi Mickael,

On Dec 21, 2009, at 5:01 PM, Mickael Auger wrote:
> I tested this new function but,
>
> - the declaration of "int i" should be at the beginning of function  
> in C strict

what do you mean exactly by "C strict" ?  As far as I know the code in  
U_CONFIG_INDENT is ok in ANSI C (and later): the 'i' inside the 'do  
{...} while (0)' is usually called a block (or local) identifier and  
its visibility extends from its declaration point inside the block to  
the end of the same block.  I've not managed to find a K&R-able  
compiler to test if it works with very old C, but I don't see any  
problem in principle.  Have you tried with a specific compiler ?

> - there are superfluous tabs such as :
> =========
>   section1
>   {
>     key value
>   }
> =========
> instead :
> =========
> section1
> {
>   key value
> }
> =========

Right, I'll push the indent level back by one.

ciao, t.